----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103806/#review10160 -----------------------------------------------------------
it looks good to me, (and proably you're right 90% of qml models a qabstractlistmodel could be enough) only thing that i am usire of is the runnerforid function components/runnermodel/runnermodel.h <http://git.reviewboard.kde.org/r/103806/#comment8360> whitespace components/runnermodel/runnermodel.cpp <http://git.reviewboard.kde.org/r/103806/#comment8357> why a direct access for the runner is needed? components/runnermodel/runnermodel.cpp <http://git.reviewboard.kde.org/r/103806/#comment8358> whitespace components/runnermodel/runnermodel.cpp <http://git.reviewboard.kde.org/r/103806/#comment8359> :) - Marco Martin On Jan. 27, 2012, 6:06 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103806/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2012, 6:06 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Adds some features to the RunnerModel so that it can be used properly in the > KRunner QML implementation I've been working on (see the testing section). > > Also it simplifies the code a bit by moving from QAbstractItemModel -> > QAbstractListModel. > > > Diffs > ----- > > components/runnermodel/runnermodel.h 899bf1f > components/runnermodel/runnermodel.cpp a226f8e > > Diff: http://git.reviewboard.kde.org/r/103806/diff/diff > > > Testing > ------- > > use it in kde:scratch/apol/krunner-qml (proof of concept for a KRunner > implemented in QtQuick). > > here's a video, so that you know what's going on: > http://www.proli.net/meu/netrunner/qmlrunner.ogv > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
