On Sunday, January 1, 2012 21:27:08 Ignat Semenov wrote: > Hello Plasma devs! > > I wanted to ask this question on IRC, but nobody's there at the > moment. So I'm asking here instead. > > I'm implementing the option to hide the selection marker in FolderView
why? i can see hiding it when double click activation is chosen for the desktop, but is there some other use case you have in mind? this should not ever be exposed in the config UI, however. it's a pixel-pushing configuration that, if we go this route as a general design principle, leads to configuration insanity. i'm fine with the idea of implementing this as a change that happens automatically when double-click-activation is on. (which is why i asked about your use case for this :) > "Click to view" button (the lower one) uses the QWidget::hide() method > in hoverEvent() and successfully hides itself. The Selection button, > on the other hand, is located above the first button, and > QWidget::hide() results in an **ugly gap**. > > Thus I have to use the QGraphicsGridLayout::removeItem() and yes, this is a known limitation in QGraphicsLayout and one that apparently will never be fixed. > void ActionOverlay::setShowSelectionMarker(bool show); > > which would add / remove the button from the layout and hide it, > resulting in a proper button alignment. > > Now if I implement this method, for consistency and symmetry, I will > have to do the same for the ClickToView button: > > void ActionOverlay::setShowClickToViewButton(bool show); sounds fine ... > The other problem with FW is that following a recent commit from Aaron > Seigo, the configAccepted() method no longer aplies settings, which is > perfectly fine per se. But, now when we click Apply or OK, the > settings are written to the disk, but are **not** applied. Tested in i tested this before committing (obviously). it also tested again just now. both in plasmoidviewer and in plasma-desktop. so i scratched my head a bit but continued testing ... finally discovered it is only broken in the case where it is being used as a containment. "when used as a containment" is a useful bit of information ;) i'm fixing it right now (problem is in kde-workspace/libs/plasmagenericshell, for the curious :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
