-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103597/#review9431
-----------------------------------------------------------

Ship it!


that's a very good catch ;)
yes, that's the way it's supposed to work.

qwidget level focus and qgraphicsscene level focus are two different beasts.

if there was another widget in that window besides the graphicsview (that is 
one single widget, just as a qpushbutton or whatnot) the reason this happens 
becomes more evident.

i think this should go in 4.8

- Marco Martin


On Dec. 31, 2011, 7:27 a.m., Nikita Churaev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103597/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2011, 7:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> For some reason, QGraphicsView must be focused too for its children to 
> receive events. This however looks hacky. Please explain why it works to me.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/controllerwindow.cpp 6f3064f 
> 
> Diff: http://git.reviewboard.kde.org/r/103597/diff/diff
> 
> 
> Testing
> -------
> 
> Works as expected.
> 
> 
> Thanks,
> 
> Nikita Churaev
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to