Hi all, Can I submit the review below? By the way, is kdelibs still closed to pushes?
Em Monday 19 December 2011, Lamarque Vieira Souza escreveu: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103469/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2011, 10:15 p.m.) > > > Review request for kdelibs and Plasma. > > > Changes > ------- > > Add KLocale::reparseConfiguration() and make KLocalePrivate::initFormat() > public. > > > Description > ------- > > This is patch number 3 to fix bug #289094 (top bar time incorrectly > displays in 24 hour format). The other patches are against plasma-mobile > and kde-workspace (http://git.reviewboard.kde.org/r/103434), all three > patches must be applied to fix the bug. I think this is a much simpler > solution than the one I suggested in > http://git.reviewboard.kde.org/r/103434. > > > This addresses bug 289094. > http://bugs.kde.org/show_bug.cgi?id=289094 > > > Diffs (updated) > ----- > > kdecore/localization/klocale.h 3495431 > kdecore/localization/klocale.cpp 499bf11 > kdecore/localization/klocale_p.h 4ed8e3f > kdeui/kernel/kglobalsettings.h cb8f7e2 > kdeui/kernel/kglobalsettings.cpp 819b314 > > Diff: http://git.reviewboard.kde.org/r/103469/diff/diff > > > Testing > ------- > > > Thanks, > > Lamarque Vieira Souza -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel