----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103468/#review9080 -----------------------------------------------------------
Ship it! I think the UI would be clearer, if there was a combobox to choose which mode to use, either geometry, or CSS selector. Disabling the geometry edit is a good step, but I think not ideal for the user. - Sebastian Kügler On Dec. 19, 2011, 11:56 a.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103468/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2011, 11:56 a.m.) > > > Review request for Plasma. > > > Description > ------- > > title says it all. this patch is related to > https://bugs.kde.org/show_bug.cgi?id=284459#c2 but does not fix that bug. > > > Diffs > ----- > > applets/webslice/plasma/webslice.h fbe1242 > applets/webslice/plasma/webslice.cpp a1740bf > > Diff: http://git.reviewboard.kde.org/r/103468/diff/diff > > > Testing > ------- > > seems to work > > > Thanks, > > Greg T > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
