----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9030 -----------------------------------------------------------
Ship it! i'm ok with this fix for now, but we need to look at making KLocale work better for us here :) plasma/generic/applets/digital-clock/clock.cpp <http://git.reviewboard.kde.org/r/103434/#comment7475> this still realy ought to be done in klocale - Aaron J. Seigo On Dec. 16, 2011, 9:13 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103434/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2011, 9:13 p.m.) > > > Review request for kdelibs and Plasma. > > > Description > ------- > > The patch resets time format in digital clock plasmoid when the user changes > the 24h configuration in active-settings. > > The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am > wondering if I should add this change to kdelibs instead of kde-workspace to > avoid duplicating code. Anyway, I wanted someone to review the code to see if > there can be any side effect. > > > This addresses bug 289094. > http://bugs.kde.org/show_bug.cgi?id=289094 > > > Diffs > ----- > > plasma/generic/applets/digital-clock/clock.h 4aec3fd > plasma/generic/applets/digital-clock/clock.cpp dd03692 > > Diff: http://git.reviewboard.kde.org/r/103434/diff/diff > > > Testing > ------- > > Works in Plasma Active. In Plasma Desktop kcmlocale does not call > KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it > does not take effect. Other kcm modules (e.g. keyboard), call emitChange. > > > Thanks, > > Lamarque Vieira Souza > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
