----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103366/#review8862 -----------------------------------------------------------
This review has been submitted with commit 5960ae9846c333ef381a817af9d63776c4ddc201 by Martin Gräßlin to branch KDE/4.7. - Commit Hook On Dec. 9, 2011, 5:18 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103366/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2011, 5:18 p.m.) > > > Review request for kwin and Plasma. > > > Description > ------- > > When the offset was not explicitly specified, the actual distance of the > window to the nearest screen edge should be used as offset. This was > calculated incorrectly resulting in broken code in the kwin effect. > > With this change a new "default" is introduced as -1 which is interpreted by > kwin as kwin has to calculate the correct offset. Now it would be possible to > do this in the library and pass the correct offset, but the library would > have to create a QDesktopWidget just to calculate the screen geometry. KWin > on the other hand knows the screen size, so having the default is IMHO better. > > Adjustments to kwin come in next patch for kde-workspace > > > This addresses bug 287602. > http://bugs.kde.org/show_bug.cgi?id=287602 > > > Diffs > ----- > > plasma/windoweffects.cpp ce41176 > > Diff: http://git.reviewboard.kde.org/r/103366/diff/diff > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
