----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8821 -----------------------------------------------------------
we tried the plasmoid with a couple of people here at the house and comments included: * the history should be remembered between restarts (e.g.: save to config) * instead of showing the result in a tooltip, it should be shown in the plasmoid itself (as if you had typed in the equation; would also make it easy to go back to an older equation and re-edit it) * the history button should be enabled only when there are items in the history * the answer should be selectable for copy/past purposes (that's not the fault of your patch, of course :) very nice improvement already though .. due to feature freeze this can't go in until 4.9 devel opens up (in january), so there remains time to improve this further. thanks for the patch, i look forward to seeing further improvements! :) applets/qalculate/qalculate_applet.cpp <http://git.reviewboard.kde.org/r/103052/#comment7382> should have {}s applets/qalculate/qalculate_history.h <http://git.reviewboard.kde.org/r/103052/#comment7383> should be const. - Aaron J. Seigo On Dec. 8, 2011, 8:48 p.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103052/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2011, 8:48 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Hey dudes, > I implemented a little menu that displays the last 10 results. improvement > ideas? > > I found this task in the plasma task list: > http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid > > > Diffs > ----- > > applets/qalculate/qalculate_applet.h aee14c0 > applets/qalculate/qalculate_applet.cpp 4da9241 > applets/qalculate/qalculate_history.h 59185ee > applets/qalculate/qalculate_history.cpp 35592a7 > > Diff: http://git.reviewboard.kde.org/r/103052/diff/diff > > > Testing > ------- > > seems to work > > > Thanks, > > Greg T > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
