----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102290/ -----------------------------------------------------------
(Updated Nov. 29, 2011, 4:42 p.m.) Review request for Plasma and Aaron J. Seigo. Changes ------- no seg fault anymore.:) (thanks Aaron) The only issue is that the QSize of the m_imageViewer is being zero when the image is threaded. So the if condition becomes useless. Do you have any idea how i can fix it? Description ------- hello, without this patch a user cannot add an image with plasmate. reproduce,go to files-images-new,the plasmate will open a text editor instead of a dialog,which(the dialog) is able to open an image. With the patch a dialog will open asking for an image. Diffs (updated) ----- CMakeLists.txt e825271 editors/CMakeLists.txt 1feb1ce editors/editpage.h 7b5dca3 editors/editpage.cpp d4b0082 editors/imageviewer/imageloader.h e69de29 editors/imageviewer/imageloader.cpp e69de29 editors/imageviewer/imageviewer.h e69de29 editors/imageviewer/imageviewer.cpp e69de29 main.cpp 66a7cd8 mainwindow.h 7d89815 mainwindow.cpp 6ea7f0c packagemodel.cpp 8c0907a Diff: http://git.reviewboard.kde.org/r/102290/diff/diff Testing ------- the patch is not ready yet,i have noted some questions. Also the plasmate tries to open the image with a text editor.This have to be fixed,but how?Should we make plasmate able to preview images? In addition,when you add something in the list of files(using the different options provided by the files qdockwidget) it names it as "new".This has to be fixed and the plasmate has to show the real name of the file.(different request,i just want an approval for this patch). Thanks, Giorgos Tsiapaliwkas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
