----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103088/#review8349 -----------------------------------------------------------
This review has been submitted with commit 44a9c26b9eb27df8297618764f988972d476dc84 by David E. Narváez to branch master. - Commit Hook On Nov. 19, 2011, 5:42 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103088/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2011, 5:42 p.m.) > > > Review request for Plasma and Christian Mollekopf. > > > Description > ------- > > As the InvisibleCollectionFetch fetch strategy is currently broken, I > implemented a suggestion by Christian Mollekopf of working around the issues > by flatting the model through a KDescendantsProxyModel to fix crashes in > Plasma related to calendars. > > > This addresses bug 279322. > http://bugs.kde.org/show_bug.cgi?id=279322 > > > Diffs > ----- > > plasma/generic/dataengines/calendar/calendarengine.cpp 53f98c0 > > Diff: http://git.reviewboard.kde.org/r/103088/diff/diff > > > Testing > ------- > > 1. Add an iCal resource from the internet > 2. Refresh the iCal resource > 3. Refresh the iCal resource again if Plasma didn't crash on step 2 > > Withouth this patch, Plasma crashes when trying to remove an item that has no > collection in the Calendar Model embedded in the Dataengine. > > You should also be able to replicate bug 279322 without this patch and this > patch should fix the situation described there. > > > Thanks, > > David Narváez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
