> On Sept. 16, 2011, 2 p.m., Aaron J. Seigo wrote: > > looks good. and stripping unecessary whitespace is good (adding unecessary > > whitespace, by corallary, is not :)
Sorry to bring this up so late - has this been applied yet? I don't have push access so I can't do it - would you do so if not, Aaron? Thanks! - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102631/#review6573 ----------------------------------------------------------- On Sept. 16, 2011, 2:10 p.m., Thomas Gahr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102631/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2011, 2:10 p.m.) > > > Review request for Plasma. > > > Description > ------- > > KControl/randr: Make changes to the absolute X/Y coordinates of a display > call setConfigDirty and thus enable the "apply" button. > In some situations the absolute X/Y position is the only thing the user needs > to change. At the moment you need to make some dummy change (change > resolution back and forth or alike) to enable the "apply" button. This is not > a good user experience. > > Sorry for the unnecessary whitespace-changes, qt-creator auto-strips > unnecessary space upon saving. If everything else is fine with this patch and > anybody insists on it I will update the patch dropping these changes. > > > Diffs > ----- > > kcontrol/randr/outputconfig.cpp 38c8386 > > Diff: http://git.reviewboard.kde.org/r/102631/diff/diff > > > Testing > ------- > > Backported the patch to kde-workspace sources 4.7.0 used in Fedora's KDE rpms > (i.e. change valueChanged(int) to textChanged(const QString&), built a new > rpm from the patched sources and tested it on my install. Works just as > expected. I have yet to finish the setup of my kde-devel environment to test > it on current master. Will keep you updated if it breaks anything. > > [update] Works fine with current master > > > Thanks, > > Thomas Gahr > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
