> On Nov. 10, 2011, 11:30 a.m., Aaron J. Seigo wrote: > > other than having to wait on the functionality in kdelibs (or performing > > the atom check directly in Task instead of relying on NetInfo), i wonder if > > this couldn't be merged into "Program Grouping" itself so that one does not > > need to choose between grouping by program or by tab collection. e.g. > > something along the lines of "group tabbed items together, everything else > > by program name" might fit the principle of least surprise and require > > people to do less configuration. thoughts?
It can't perform the atom check directly in in libtaskmanager as it also needs to get changes directly, which wouldn't be easy to do in ltm directly. The merge with programgroupingstrategy would need some discussion, how it should exactly handle conflicts, and could irritate the user if not done correctly (not sure how to do it correctly), so I would prefer to let it wait till after the feature freeze (And then wait till 4.9 or push it as a bug-fix). > On Nov. 10, 2011, 11:30 a.m., Aaron J. Seigo wrote: > > libs/taskmanager/strategies/wintabgroupingstrategy.cpp, lines 96-97 > > <http://git.reviewboard.kde.org/r/103101/diff/1/?file=40755#file40755line96> > > > > there is no point in doing qobject_casts if the values are never > > checked. either check the values or use static_casts Well I copied that part one by one from programgroupingstrategy, but I'm fine with changing it to static_cast. > On Nov. 10, 2011, 11:30 a.m., Aaron J. Seigo wrote: > > libs/taskmanager/strategies/wintabgroupingstrategy.cpp, line 101 > > <http://git.reviewboard.kde.org/r/103101/diff/1/?file=40755#file40755line101> > > > > indented too far - Anton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103101/#review8094 ----------------------------------------------------------- On Nov. 10, 2011, 3:59 p.m., Anton Kreuzkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103101/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2011, 3:59 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch adds a groupingstrategy that groups tasks by their tab group, from > kwin's window tabbing feature. > Most of the code in wintabgroupingstrategy is copied from > programgroupingstrategy. > This patch is based on https://git.reviewboard.kde.org/r/103099/ to be > included in KDELibs 4.7 > > > This addresses bug 224690. > http://bugs.kde.org/show_bug.cgi?id=224690 > > > Diffs > ----- > > libs/taskmanager/CMakeLists.txt c3848cf > libs/taskmanager/groupmanager.h 760ddf1 > libs/taskmanager/groupmanager.cpp b66c6fa > libs/taskmanager/strategies/wintabgroupingstrategy.h PRE-CREATION > libs/taskmanager/strategies/wintabgroupingstrategy.cpp PRE-CREATION > libs/taskmanager/task.h aa05176 > libs/taskmanager/task_x11.cpp 9b7d8cb > > Diff: http://git.reviewboard.kde.org/r/103101/diff/diff > > > Testing > ------- > > Tested without problems so far. > > > Thanks, > > Anton Kreuzkamp > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
