> On Nov. 9, 2011, 4:25 p.m., Aaron J. Seigo wrote: > > other than the small issue with QDir, it looks good to me ... it's Craig's > > widget though so he has to have the last say to ship it or not.
Thank you a lot :) I'll wait for Craig's approval, if he agrees with the changes :) - Diego ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/#review8049 ----------------------------------------------------------- On Nov. 9, 2011, 4:33 p.m., Diego Casella wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103092/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2011, 4:33 p.m.) > > > Review request for Plasma and Craig Drummond. > > > Description > ------- > > Simple patch which makes IconTask look more consistent with Plasma Theme. > It renders the "close" button using Plasma::Theme, and fallback to the > standard window-close icon if nothing better is available :) > > > Diffs > ----- > > applets/icontasks/tooltips/windowpreview.cpp 3e0c865 > > Diff: http://git.reviewboard.kde.org/r/103092/diff/diff > > > Testing > ------- > > Compiles and works as expected (see pictures below). > > > Screenshots > ----------- > > ToolTip with themed "close" button > http://git.reviewboard.kde.org/r/103092/s/329/ > ToolTip with default "close" icon > http://git.reviewboard.kde.org/r/103092/s/330/ > ToolTip with themed "closed" button, resized > http://git.reviewboard.kde.org/r/103092/s/331/ > > > Thanks, > > Diego Casella > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
