> On Nov. 5, 2011, 10:39 a.m., Aaron J. Seigo wrote: > > kmenuedit/basictab.cpp, line 141 > > <http://git.reviewboard.kde.org/r/103051/diff/1/?file=40278#file40278line141> > > > > this line can probably just be removed and let KIconButton chose the > > optimal size?
This doesn't seem to work since KIconButton chooses 48, which hides the button borders. I checked kpropertiesdialog.cpp in kdelibs and it also sets the icon size manually. - Hans ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103051/#review7965 ----------------------------------------------------------- On Nov. 5, 2011, 12:06 a.m., Hans Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103051/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2011, 12:06 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Decrease the KIconButton icon size in KMenuEdit to allow the button to draw a > border. > > The issue is that without a border, it's not clear that you can click on the > icon to change it. This is especially true for new entries that don't have an > icon at all (currently it just shows a gray empty space). This patch makes > the icon button more similar to the one in the properties dialog of Dolphin. > > > Diffs > ----- > > kmenuedit/basictab.cpp 4953786 > > Diff: http://git.reviewboard.kde.org/r/103051/diff/diff > > > Testing > ------- > > Tested in master with the default Oxygen style. > > > Screenshots > ----------- > > Difference: Before vs After > http://git.reviewboard.kde.org/r/103051/s/323/ > > > Thanks, > > Hans Chen > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
