> On Nov. 3, 2011, 7:38 a.m., Aaron J. Seigo wrote: > > Ship It! > > Max Lin wrote: > Should I push to master and 4.7 branch? or just only master? > > Thanks a lot!
since it is a bug fix (and a crash fix no less!) please push to both 4.7 and master. thanks! :) - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103035/#review7888 ----------------------------------------------------------- On Nov. 3, 2011, 4:15 a.m., Max Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103035/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2011, 4:15 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Checking the return value of gps_open() as condition instead of checking > m_gpsdata for GPSD_API_MAJOR_VERSION >=5, there should be prevent crash > occurred when no gpsd running. Since m_gpsdata is instanced, there will be > always consider gpsd found when no gpsd running, there should be check return > value of gps_open() is not -1. > > > This addresses bug 277036. > http://bugs.kde.org/show_bug.cgi?id=277036 > > > Diffs > ----- > > plasma/generic/dataengines/geolocation/location_gps.cpp 709321b > > Diff: http://git.reviewboard.kde.org/r/103035/diff/diff > > > Testing > ------- > > Testing this patch with gpsd 2.96(GPSD_API_MAJOR_VERSION >=5) on trunk and > openSUSE Factory, it works and some plasmoids(weather, weatherstation..) > which with gpsd support are not crash anymore. However, unfortunately, I have > no real gps device to test the function with gps device plugged, but I think > this patch should be no broken somewhere with gps device plugged. > > > Thanks, > > Max Lin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
