> On Oct. 27, 2011, 2:46 p.m., Mark Gaiser wrote: > > A suggestion. Some KDE releases back there was a display icon that used the > > selected wallpaper as image on the display (later the entire display got > > removed). You made some nice icons, but i think it's better to look back in > > the code how it was done when the display was still there and use that > > instead. It was certainly 2 KDE releases back so i guess you can certainly > > find it if you look in the same code from KDE 4.4.
Ahh, got it: http://quickgit.kde.org/?p=kde-workspace.git&a=commit&h=02c5c3941b831a78c883b5bd8cbfc4ba3802e63d So it became optional.. But that should give you an idea of where to look. And in some later revision it got removed (sadly since it was looking quite fancy), can't see which one since kde's quickgit seems to be offline a.t.m. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102978/#review7690 ----------------------------------------------------------- On Oct. 27, 2011, 1:35 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102978/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2011, 1:35 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch changes the generic text-ish dropdown box into six icon'd buttons > that let you visually choose your layout, i.e. instead of choosing "Centered" > you click on the monitor icon with the KDE logo centered etc. See screenshot > for how it looks, I cannot really describe that. > There are then six new icons in 128x128 which I attach as zip file. I am not > an artist but KolourPaint is awesome ;) > Somehow git did not include the CMakeLists.txt in the icons/ subdirectory I > created (kde-workspace/plasma/generic/wallpapers/image/icons), although I > added it. The CMakeLists.txt file in said directory only contains > "KDE4_INSTALL_ICONS( ${ICON_INSTALL_DIR} )" to install the icons. > > > Diffs > ----- > > plasma/generic/wallpapers/image/CMakeLists.txt 2a4c2a3 > plasma/generic/wallpapers/image/image.h 417f5a7 > plasma/generic/wallpapers/image/image.cpp 006a748 > plasma/generic/wallpapers/image/imageconfig.ui 793f0ea > plasma/generic/wallpapers/image/slideshowconfig.ui 144d437 > > Diff: http://git.reviewboard.kde.org/r/102978/diff/diff > > > Testing > ------- > > Compiles and works. > Clicking on a resize method button checks this button and after applying the > changes, the wallpaper layout changes. Works for both Single Image and > Slideshow modes. > (Would be nice if the changes were applied right after changing but I > couldn’t figure out how this is done) > > > Screenshots > ----------- > > Screenshot > http://git.reviewboard.kde.org/r/102978/s/319/ > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
