----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102878/#review7380 -----------------------------------------------------------
The "12" case needs to be fixed to account for the last two digits, so that it becomes 312th, not 312nd. Maybe it should be added to KLocale? Some languages might have completely different requirements depending on the number, so the we have a central place to add code to handle them. - Christoph Feck On Oct. 15, 2011, 10:38 p.m., Trever Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102878/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2011, 10:38 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Does pretty much what it says on the tin. > > No more strings that say "2th". Fixed to handle 1st, 2nd, 3rd, 282nd, 12th, > etc. > > Brought up by this reddit thread: > http://www.reddit.com/r/linux/comments/ld8ow/really_kde/ > > > Diffs > ----- > > libs/plasmaclock/clockapplet.h ed6230f > libs/plasmaclock/clockapplet.cpp 4f16cb1 > > Diff: http://git.reviewboard.kde.org/r/102878/diff/diff > > > Testing > ------- > > Spun the spinbox. > > > Thanks, > > Trever Fischer > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
