> On Oct. 5, 2011, 1:58 a.m., Aaron J. Seigo wrote: > > thanks for the patch ... :) > > > > the coding style should follow the kdelibs style, but that's a minor thing. > > mostly just the one question regarding something noted in a code comment:
I can run the file through the astyle command before commiting. As for the alpha channel, the note is there mainly in case somebody tries to use the function also in the future. For setBackgroundPixmap() it shouldn't matter AFAICT, and paintEvent() does a transparent fill after the transformation, so icons with translucent areas work fine. - Luboš ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102770/#review7095 ----------------------------------------------------------- On Oct. 4, 2011, 3:31 p.m., Luboš Luňák wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102770/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2011, 3:31 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This patches changes systemtray handling of XEmbed-based clients from various > Xlib code to plain Qt code. The Xlib code was presumably introduced to handle > non-native Qt graphics systems, but that can be somewhat more cleanly handled > by forcing Qt to create XPixmap-based QPixmap. > > > Diffs > ----- > > plasma/generic/applets/systemtray/protocols/fdo/x11embedcontainer.h fa47b9b > plasma/generic/applets/systemtray/protocols/fdo/x11embedcontainer.cpp > 0aa5d96 > > Diff: http://git.reviewboard.kde.org/r/102770/diff/diff > > > Testing > ------- > > Tested with plasma-desktop and licq, with and without compositing enabled, > seems to work the same way like without the patch. > > > Thanks, > > Luboš Luňák > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
