-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102621/
-----------------------------------------------------------
(Updated Sept. 21, 2011, 7:57 p.m.)
Review request for Plasma.
Changes
-------
One more try.
Summary (updated)
-------
The third verion of this patch does:
* Shows the city, UTC displacement, and time in one line and the date (I hope
English people say "on the" where Spanish people say "del día"), in another
line, always complete.
* removes a <table> that makes the rendering harder
* adds a <br> to include an space between the dates and the event.
Look at the screnshot.
In any case, I think one part of this patch MUST be commited.
* removes a <table> that makes the rendering harder
* adds a <br> to include an space between the dates and the event.
That is, replace
if (!subText.isEmpty()) {
subText.prepend("<table>"); subText is never empty as is
created with QString("<table>")
subText.append("</table>");
}
with
subText.append("</table><br>");
Of course, kwarning() << data; is not there anymore.
This addresses bug 260394.
http://bugs.kde.org/show_bug.cgi?id=260394
Diffs (updated)
-----
libs/plasmaclock/clockapplet.cpp b1275af
Diff: http://git.reviewboard.kde.org/r/102621/diff
Testing
-------
Checked with zero, one and several timezones with short and large city names in
two machines.
Screenshots
-----------
version 2
http://git.reviewboard.kde.org/r/102621/s/262/
showing also the UTC displacement
http://git.reviewboard.kde.org/r/102621/s/267/
Thanks,
Jaime Torres
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
