----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102464/#review6120 -----------------------------------------------------------
what is the use case for this? introducing configuration options that the user must then manage which control UI details like which widgets to show are something we try to avoid to preserve ease of use and elegance. if there is a real need for scrollbars in this widget, could they be turned on/off automatically instead? applets/webslice/kgraphicswebslice.cpp <http://git.reviewboard.kde.org/r/102464/#comment5392> needs to follow the same code style as the rest of the code, in this case that would mean: if (scrollbar) { .... } else { .... } applets/webslice/plasma/webslice.cpp <http://git.reviewboard.kde.org/r/102464/#comment5391> simpler/clearer would be: m_scrollbar = ui.scrollBarEnabled->isChecked(); m_slice->setScrollbar(m_scrollbar); cg.writeEntry("scrollbar", m_scrollbar); - Aaron J. On Aug. 27, 2011, 7:58 p.m., Javier Llorente wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102464/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2011, 7:58 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > I have basically added a function to enable/disable the scrollbar on Web > Slice. > > > Diffs > ----- > > applets/webslice/kgraphicswebslice.h > dfb60e5b0b3765f8e2324f832f78a1abac0db510 > applets/webslice/kgraphicswebslice.cpp > 6c976a0f8250e11ffb9dc4e85e122433f86a073a > applets/webslice/kwebslice.cpp c1eb9ea8da64129765ad68044f2b7d038387b08b > applets/webslice/plasma/webslice.h fbe12420ea372c6f1b073a4f047a6cbb742cc0a0 > applets/webslice/plasma/webslice.cpp > a1740bfd62dd91401a366a240e83e6b84509f81c > applets/webslice/plasma/websliceConfig.ui > b3ac77608ec66e1be1ebca04488ae19318163a75 > > Diff: http://git.reviewboard.kde.org/r/102464/diff > > > Testing > ------- > > > Thanks, > > Javier > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
