----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102290/#review5616 -----------------------------------------------------------
editors/editpage.cpp <http://git.reviewboard.kde.org/r/102290/#comment5031> it should start wherever the default desktop wide location is, and re-open to the last used directory (if any). you can control where it starts with setUrl editors/editpage.cpp <http://git.reviewboard.kde.org/r/102290/#comment5020> any: peg, png, svg ... editors/editpage.cpp <http://git.reviewboard.kde.org/r/102290/#comment5027> no point in newing this; and rightnow it is leaking as it is never deleted. editors/editpage.cpp <http://git.reviewboard.kde.org/r/102290/#comment5028> foreach ( <-- whitespace :) packagemodel.cpp <http://git.reviewboard.kde.org/r/102290/#comment5030> i would probably write this as: if (index.row() == 0) { if (qstrcmp(key, "images") { return QStringList("[plasmate]/image"); } return QStringList("[plasmate]/new"); } clearer to understand that the important thing is that it's the first item in the branch (row() == 0) and that different types are returned depending on where in the package we are. - Aaron J. On Aug. 10, 2011, 6:29 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102290/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2011, 6:29 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Summary > ------- > > hello, > > without this patch a user cannot add an image with plasmate. > > reproduce,go to files-images-new,the plasmate will open a text editor instead > of a dialog,which(the dialog) is able to open an image. > > With the patch a dialog will open asking for an image. > > > Diffs > ----- > > editors/editpage.h 7b5dca3 > editors/editpage.cpp d4b0082 > packagemodel.cpp 8c0907a > > Diff: http://git.reviewboard.kde.org/r/102290/diff > > > Testing > ------- > > the patch is not ready yet,i have noted some questions. > Also the plasmate tries to open the image with a text editor.This have to be > fixed,but how?Should we make plasmate able to preview images? > > In addition,when you add something in the list of files(using the different > options provided by the files qdockwidget) it names it as "new".This has to > be fixed and the plasmate has to show the real name of the file.(different > request,i just want an approval for this patch). > > > Thanks, > > Giorgos > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
