> On Aug. 9, 2011, 2:14 p.m., Martin Gräßlin wrote: > > I'm not sure, but I think something was added to keybindings.cpp already, > > but I like this approach better :-)
You're right - kwinbindings.cpp does include a "Lock Screen" shortcut, but it will never actually aquire Ctrl+Alt+L (on an existing desktop), as it does not release KRunner's claim on that shortcut. I'll update this request to include removing that definition. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102261/#review5548 ----------------------------------------------------------- On Aug. 9, 2011, 12:52 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102261/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2011, 12:52 p.m.) > > > Review request for kwin, Plasma, Aaron J. Seigo, Martin Gräßlin, and Farhad > Hedayati Fard. > > > Summary > ------- > > In the farhad_hf/lockscreen branch (that moves screen locking functionality > from krunner to kwin), the shortcut for locking the screen (Ctrl+Alt+L by > default) remains in KRunner, which will not necessarily be running (when > plasma is in "netbook" mode, for example). This moves the shortcut > registration to kwin (including a necessary hack for unregistering krunner's > claim on it). > > (See also https://git.reviewboard.kde.org/r/101943/ ). > > I can also merge latest master into the branch and/or add in a > KWIN_BUILD_SCREENSAVER cmake option (as in the original review request) if > you (Martin/Farhad) want. > > > Diffs > ----- > > krunner/krunnerapp.cpp 55ac5ca > kwin/screenlocker/screensaver/saverengine.h 3384d4a > kwin/screenlocker/screensaver/saverengine.cpp 6c15be6 > kwin/useractions.cpp 44685b9 > > Diff: http://git.reviewboard.kde.org/r/102261/diff > > > Testing > ------- > > > Thanks, > > Alex > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
