> On July 11, 2011, 6:27 p.m., Giorgos Tsiapaliwkas wrote: > > projectmanager/projectmanager.cpp, lines 73-79 > > <http://git.reviewboard.kde.org/r/101916/diff/1/?file=26726#file26726line73> > > > > Why in general the destructors of plasmate doesn't do something like > > that?? > > Aaron J. Seigo wrote: > the more typical approach is to parent those items to something and let > QObject handle it. > > e.g. this: > > m_loadButton = new KPushButton(i18n("Load Project")); > > should become this: > > m_loadButton = new KPushButton(i18n("Load Project"), this); > > there's no need for a dtor then. > > Giorgos Tsiapaliwkas wrote: > so,i will replace evething that is necessary with the "this". > Is that ok??
yep, that should work fine... parent the widgets and then commit :) - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101916/#review4605 ----------------------------------------------------------- On July 11, 2011, 6:12 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101916/ > ----------------------------------------------------------- > > (Updated July 11, 2011, 6:12 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > hello, > > I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed that > there wasn't no destructor. > The patch adds a destructor at projectmanager and changed a bit the > mainwindow.cpp. > > I have some question in my next reply > > > Diffs > ----- > > mainwindow.cpp e08581f > projectmanager/projectmanager.h 53ef226 > projectmanager/projectmanager.cpp 122e48d > > Diff: http://git.reviewboard.kde.org/r/101916/diff > > > Testing > ------- > > compiles fine and no pointer error > > > Thanks, > > Giorgos > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
