On Friday 15 July 2011, Aaron J. Seigo wrote: > > anyways.. the thing i'm contemplating is this: > > Removing all the "load(..)" methods from the classes, and instead have > everything use PluginManager directly.
+1 > pros: > * fewer methods in general in the API, particularly ones that plugin > writers don't care about > * it follows the pattern now done with Package which handles all package > loading instead of per-class API for that (in fact, it goes one better: > Package::load would also disappeaer) > * consistent way for loading plugins: use PluginLoader > > cons: > * code like Applet::load becomes PluginLoader::self()->loadApplet. in > other words, rather more verbose. i could change PluginLoader to instead > of "having loadApplet" or "loadDataEngine" just "applet" and "dataEngine" i don't see it *so* a con: - it's very clear what it does - it's not exactly code that will be used all over the place, mostly in libplasma itself and in the shells, "normal" users of libplasma (plasmoids, dataengines etc) would barely see this, with the possible exception of who uses the kpart, but even then they would have this code only in a couple of places Cheers, Marco Martin _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
