> On July 6, 2011, 1:31 p.m., Aaron J. Seigo wrote:
> > what is the use case for the checkbox? it is nicely implemented and all,
> > but i'm not sure what the real value of it is, versus the cost of having it
> > in the user interface and making it more complex?
> >
> > also, the set of buttons makes the dialog rather wide now. i wonder if it
> > wouldn't be nicer to make Remove Project a button with a menu containing
> > "From project list" and "From disk" as entries? this would make the window
> > smaller and reduce some visual duplication ("Remove Project" x 2) while
> > nicely clustering the options.
>
> Giorgos Tsiapaliwkas wrote:
> a KComboBox should do the work.Do you agree?
>
> Do you want to remove all the relevant code for cancelRemoveButton?
>
> Imo,i just wrote this code cuz it was a TODO,since there are the
> KMessageBoxes i thing that it is useless to have a qcheckbox.
you don't need a KComboBox.. you can add a QMenu (or a KMenu, for that matter)
to [QK]PushButton with QPushButton::setMenu(QMenu *menu).
and yes, i think all the checkbox related code can go.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101585/#review4463
-----------------------------------------------------------
On July 6, 2011, 1:16 p.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101585/
> -----------------------------------------------------------
>
> (Updated July 6, 2011, 1:16 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> hello,
>
> the following patch is a summary of some other patches that i had to my local
> repository.Because it is too difficult to make different request due to share
> code i made 1 review request.(Sorry for the inconvinience.)
>
> This patch shares code with these two.
> git.reviewboard.kde.org/r/101535/
> git.reviewboard.kde.org/r/101584/
>
> The patch adds a Qcheckbox which enables the user to protect one project from
> the removal.
> Also the delete buttons were able to be used even if a project wasn't
> selected at all,with this patch not anymore.
>
> The code lacks only in the storage possibility.Plasmate is not able to
> "remember" which projects are selected or not,i will fix this later.
>
> P.S.:i created the checkbox with some intelligence in order to work only when
> it is supposed to work.For example,only when the user selects a project.
>
>
> Diffs
> -----
>
> mainwindow.cpp 2ca2b64
> projectmanager/projectmanager.h d24ef19
> projectmanager/projectmanager.cpp 42a28f3
> startpage.h 6d45e02
> startpage.cpp 3d0c0d9
>
> Diff: http://git.reviewboard.kde.org/r/101585/diff
>
>
> Testing
> -------
>
> compiles fines,tested by me.
>
>
> Thanks,
>
> Giorgos
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
