Looks like you forgot to add datarequest.cpp to CMakeLists (see line
16), so from obsdataengine's point of view, it has no clue what you're
talking about.
Also, please, please, like I said before, go over the KDElibs code
style policy and apply it to all of this code. Maybe you didn't get to
it since I last spoke to you, or perhaps you forgot.
Either way, e.g. operators & parenth's need to have spaces, if
statement brackets need to be on the same line, e.g. the following..
ObsDataEngine::ObsDataEngine(QObject* parent,const QVariantList&
args):Plasma::DataEngine(parent,args
should (a) have a space between the colon, and/or (b) be on a
new-line. perhaps the latter will look best.
And yes, I'm quite anal vis a vis coding style ;)
In addition, your repository has build files committed to it, like I
also had mentioned earlier on IRC. Please remove them. The non src
files that should be there are CMakeLists. This means rm
*.{moc,cmake,files} as well as the dirs and makefile..
--
Shaun Reich,
KDE Software Developer (kde.org)
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
