2011/5/9 Aaron J. Seigo <ase...@kde.org> > On Saturday, May 7, 2011 14:13:04 Martin Klapetek wrote: > > > in any case, the fix would be pretty simple. the code is in kde- > > > runtime/knotify/notifybypopup.cpp .. at a quick glance it looks like > > > simply checking for an icon on the KNotifyConfig* that is handed in to > > > the notify method would suffice. perhaps this could even be done in the > > > getAppCaptionAndIconName method. > > > > Great, I'll have a look. Would this patch be accepted for 4.7 or is it > > already too late? > > probably too late for the 4.7 schedule, but we can put into git at least > where > it will be ready for merging. if it was a smaller feature set i might > suggest > we try and cheat a bit since we aren't at hard freeze yet, but it's a > fairly > significant change that will affect public api in kdelibs, knotify and > eventually a key plasmoid :) >
Ok, I think we can live with this for a while. I'll work on this later this week and then I'll post a patch to reviewboard. Is that ok with you? --Marty > > -- > Aaron J. Seigo > humru othro a kohnu se > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 > > KDE core developer sponsored by Qt Development Frameworks > > _______________________________________________ > KDE-Telepathy mailing list > kde-telepa...@kde.org > https://mail.kde.org/mailman/listinfo/kde-telepathy > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
