-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101321/#review3231
-----------------------------------------------------------
this must not be included in the default bindings set. it must become an
extension, just as HTTP and NetworkIO are. i'm not entirely convinced that raw
Socket access is needed, though the other half of me can imagine scenarios
where it is. ;) in any case, see:
http://techbase.kde.org/Development/Tutorials/Plasma/JavaScript/API#Extensions
also: what are your use cases? and where are the test cases you are using this
with?
finally, the methods that represent setters and getters should not be marked as
scriptable but instead by exported as Q_PROPERTIES.
i hope the above doesn't sound overly negative, as i'm very happy that there is
someone contributing to these bindings. i think this is the first major
contribution outside of core plasma hackers :)
plasma/scriptengines/javascript/simplebindings/socket.h
<http://git.reviewboard.kde.org/r/101321/#comment2728>
this should be a property
plasma/scriptengines/javascript/simplebindings/socket.h
<http://git.reviewboard.kde.org/r/101321/#comment2729>
this should be a property
plasma/scriptengines/javascript/simplebindings/socket.h
<http://git.reviewboard.kde.org/r/101321/#comment2730>
this should be a property
- Aaron J.
On May 9, 2011, 6:10 p.m., Sebastian Sauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101321/
> -----------------------------------------------------------
>
> (Updated May 9, 2011, 6:10 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This patch adds bindings for QSocket to the Plasma Javascript engine. The
> idea is to enable low-level access to QSocket to allow dealing with online-
> and remote-services.
>
> Does there exist a security-/authentification solution this needs to
> integrate with?
>
>
> Diffs
> -----
>
> plasma/scriptengines/javascript/CMakeLists.txt 1451e16
> plasma/scriptengines/javascript/plasmoid/simplejavascriptapplet.cpp 0076cd8
> plasma/scriptengines/javascript/simplebindings/socket.h PRE-CREATION
> plasma/scriptengines/javascript/simplebindings/socket.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/101321/diff
>
>
> Testing
> -------
>
> Works fine with my testcases.
>
>
> Thanks,
>
> Sebastian
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
