----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101278/#review3101 -----------------------------------------------------------
Ship it! looks fine, though i'd prefer not using underscores (something we avoid in the coding style :) experimental/libkdeclarative/bindings/icon.cpp <http://git.reviewboard.kde.org/r/101278/#comment2632> iconCtor experimental/libkdeclarative/bindings/url.cpp <http://git.reviewboard.kde.org/r/101278/#comment2631> urlCtor - Aaron J. On May 2, 2011, 10:21 p.m., Nicolas Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101278/ > ----------------------------------------------------------- > > (Updated May 2, 2011, 10:21 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > kdelibs compilation is broken with KDE4_ENABLE_FINAL turned ON. One of the > problems is in libkdeclarative, where there's two file-static functions with > the same name (ctor) and different code. These functions are used as function > pointers when creating the QScript function objects. > > Fixed by renaming the two functions to icon_ctor and url_ctor. > > > Diffs > ----- > > experimental/libkdeclarative/bindings/icon.cpp > 24885fa9d55b01388c681ec1766b659474fc40d7 > experimental/libkdeclarative/bindings/url.cpp > 21c7aa2227ea4ee10a15239905553bab40687fc5 > > Diff: http://git.reviewboard.kde.org/r/101278/diff > > > Testing > ------- > > Compilation of kdelibs with and without final. Didn't try installing or > running. > > > Thanks, > > Nicolas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
