> On April 26, 2011, 4:14 p.m., Aaron J. Seigo wrote: > > took a quick look through it and didn't see anything that popped out as > > "wrong"; seems to work as well. > > > > the config UI and dialogs for this plasmoid needs some serious work though > > :/
Yeah, I think about only supporting tabs --> hiding them in fact if there is just one. This alone would make the ui a little easier, as well as removing the option to hide the tabs. Btw. do you know what I have to do that the plasma job tracker displays an error message for a specific job? Or would I have to display a seperate message via a KNotification::event? - Matthias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101235/#review2898 ----------------------------------------------------------- On April 26, 2011, 9:47 a.m., Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101235/ > ----------------------------------------------------------- > > (Updated April 26, 2011, 9:47 a.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Summary > ------- > > Adds possiblity to create a Comic Book Archive (.cbz) for a range: All, > BeginTo, EndTo, Range > > The job is displayed using the global job tracker, though atm. I have not > implemented the total number of files that have to be downloaded, since that > is more complicated. I might do that later. > > There is one thing I don't understand. How do I set an error that the job > tracker ui will also display it? The way I am setting the error apparntly did > not result in the plasma job ui tracker to display it. > > > Diffs > ----- > > applets/comic/CMakeLists.txt 8513d9c > applets/comic/comic.h 7134c72 > applets/comic/comic.cpp 88a2e31 > applets/comic/comicarchivedialog.h PRE-CREATION > applets/comic/comicarchivedialog.cpp PRE-CREATION > applets/comic/comicarchivedialog.ui PRE-CREATION > applets/comic/comicarchivejob.h PRE-CREATION > applets/comic/comicarchivejob.cpp PRE-CREATION > dataengines/comic/comicprovider.cpp 73f1791 > > Diff: http://git.reviewboard.kde.org/r/101235/diff > > > Testing > ------- > > > Thanks, > > Matthias > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
