> On April 7, 2011, 2:45 p.m., Aaron J. Seigo wrote: > > the white space should mimic the whitespace usage in the plasmoid (e.g. > > spaces within parentheses). it's not the kdelibs or plasma style, but > > components in plasma-addons are allowed to deviate from that at their > > authors discretion, and those deviations should be respected when making > > changes to them :)
Yeah. I just kinda got fed up by that style. :D And since I am the only one working on the comic plasmoid I thought to change it silently. ;) - Matthias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101046/#review2458 ----------------------------------------------------------- On April 7, 2011, 2:08 p.m., Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101046/ > ----------------------------------------------------------- > > (Updated April 7, 2011, 2:08 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Summary > ------- > > The comic plasmoid uses prefetching by calling > Plasma::DataEngine::query(source). > Yet apparantly these created sources do not get removed automatically (?) > causing an increase of memory usage the more comics are viewed. > > E.g. looking at 15 strips of Lackadaisy that had not been cached before > caused a memory usage of 114 MB for the plasmoidviewer. The patch reduces the > usage in the same case to 52.9 MB. Each of these comics has a size between > 1.2 MB and 2.6 MB. > So please comment on the patch! :) > > I wonder why it is still that high with the patch after looking at some > comics, so if you can help to reduce that further that would be great. > Further I wonder if some of the perceived "plasma mem leak" reports are > caused by the way the comic plasmoid works. > > > Diffs > ----- > > applets/comic/CMakeLists.txt 8513d9c > applets/comic/comic.h 7134c72 > applets/comic/comic.cpp 3785f4f > applets/comic/prefetcher.h PRE-CREATION > applets/comic/prefetcher.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/101046/diff > > > Testing > ------- > > > Thanks, > > Matthias > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
