----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100750/#review1761 -----------------------------------------------------------
Ship it! nice idea :) there is a string translation (localization) issue on lines 615-617 and a handful of whitespace issues. once those are addressed, please commit. plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/100750/#comment1451> the strings need to be wrapped in i18n, e.g. i18n("Empty") plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/100750/#comment1453> instead of "if (!m_blankLabel)" with the "if it is blank" in the else, please reverse for readability so it is "if (m_blanLabel) { .." plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/100750/#comment1452> should be on same line: } else { plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/100750/#comment1454> should be on same line plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/100750/#comment1455> should be on same line plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/100750/#comment1456> should be on same line - Aaron J. On March 3, 2011, 1:39 p.m., Farhad Hedayati Fard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100750/ > ----------------------------------------------------------- > > (Updated March 3, 2011, 1:39 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > Let the user set a blank label. The label should not take up any space when > it is blank. > > > Diffs > ----- > > plasma/applets/folderview/folderview.h 2241b12 > plasma/applets/folderview/folderview.cpp f604277 > > Diff: http://git.reviewboard.kde.org/r/100750/diff > > > Testing > ------- > > Works fine here! > > > Screenshots > ----------- > > folderview configuration dialog > http://git.reviewboard.kde.org/r/100750/s/84/ > folderview with blank label > http://git.reviewboard.kde.org/r/100750/s/85/ > > > Thanks, > > Farhad > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
