----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100719/#review1598 -----------------------------------------------------------
Ship it! really interesting idea; i'm not 100% convinced, but i'm highly intrigued. let's put this into master and see how it works out over the next few months. then let's come back to it before the betas and decide whether to keep it or not. there are some minor whitespace issues that need addressing. plasma/desktop/containments/desktop/desktop.h <http://git.reviewboard.kde.org/r/100719/#comment1369> no space before the ( plasma/desktop/containments/desktop/desktop.cpp <http://git.reviewboard.kde.org/r/100719/#comment1370> should be one the same line: } else { - Aaron J. On Feb. 22, 2011, 9:14 p.m., Vitor Boschi da Silva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100719/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2011, 9:14 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > Launches krunner whenever a alphanumeric key is pressed and the desktop is > focused. The query is set to the pressed key so the user can continue to type > it. > > > Diffs > ----- > > plasma/desktop/containments/desktop/CMakeLists.txt 1cc2766 > plasma/desktop/containments/desktop/desktop.h 1d8382d > plasma/desktop/containments/desktop/desktop.cpp 41ae513 > > Diff: http://git.reviewboard.kde.org/r/100719/diff > > > Testing > ------- > > KRunner is correctly launched and other plasmoids still works when focused. > > > Thanks, > > Vitor Boschi da > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
