----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100586/#review1293 -----------------------------------------------------------
Ship it! looks like a good catch; two small suggestions below, but otherwise this is a "ShipIt!" from me. plasma/widgets/scrollwidget.cpp <http://git.reviewboard.kde.org/r/100586/#comment1078> should also ignore() the event here. plasma/widgets/scrollwidget.cpp <http://git.reviewboard.kde.org/r/100586/#comment1079> hm.. should it even return here as well? no interesting input -> not animation changes? - Aaron J. On Feb. 6, 2011, 5:10 p.m., Lasse Liehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100586/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2011, 5:10 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > I was just wondering if this is a bug and if this is the right way to solve > it, so made a review request. > > > Diffs > ----- > > plasma/widgets/scrollwidget.cpp b7cc01d > > Diff: http://git.reviewboard.kde.org/r/100586/diff > > > Testing > ------- > > Compiles, pressing Esc closes the widgets explorer even when ScrollWidget has > focus. > > > Thanks, > > Lasse > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
