----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100568/#review1231 -----------------------------------------------------------
plasma/generic/dataengines/calendar/CMakeLists.txt <http://git.reviewboard.kde.org/r/100568/#comment1035> shouldn't be necessary: akonadi is already found! plasma/generic/dataengines/calendar/calendarengine.cpp <http://git.reviewboard.kde.org/r/100568/#comment1036> indentation incorrect :) both this and the #ifdef should not be indented at all - Aaron J. On Feb. 4, 2011, 10:31 p.m., Theo Chatzimichos wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100568/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2011, 10:31 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > Previously, kde-workspace/plasma/generic/dataengines/CMakeLists.txt required > kdepimlibs compiled with akonadi-server support. The following patch makes it > conditional. Patch originally reported in gentoo bug 350850 [1] by > fabianoengler at gmail dot com > > [1] https://bugs.gentoo.org/350850 > > > Diffs > ----- > > plasma/generic/dataengines/CMakeLists.txt 4664a02 > plasma/generic/dataengines/calendar/CMakeLists.txt d3d76e6 > plasma/generic/dataengines/calendar/calendarengine.cpp 0fdd65d > > Diff: http://git.reviewboard.kde.org/r/100568/diff > > > Testing > ------- > > > Thanks, > > Theo > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel