----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100557/#review1227 -----------------------------------------------------------
Ship it! looks good; i do think we should centralize this kind of thing, however, so we can change it if need be in just one place. kcontrol/keyboard/keyboard_applet.cpp <http://git.reviewboard.kde.org/r/100557/#comment1033> ws - Aaron J. On Feb. 4, 2011, 2:10 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100557/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2011, 2:10 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > a sore point in the styling right now is the text in the systray area, so the > keyboard layout indicator and the clock looking a bit out of place compared > to the systray icon styling. > now, if we exclude doing an entire font in svg (and i really don't wan that > ;) we can come to some approximations: > it uses a svg similar to the texture of the systray icons as text background, > and a very light blur that looks more like an outline. > a theme can quite costumize it by changing the widgets/textbackground svg. > still to do, making the shadow more configurable in color and position. > This could go in Plasma::PaintUtils, but i would rather duplicate it here and > in the clock for now, to avoid it being abused too easily (can get ugly and > is a bit expensive to generate) > > > Diffs > ----- > > kcontrol/keyboard/keyboard_applet.h > 2fb9c98fde72f48a20dd853477e620a4da61aa1a > kcontrol/keyboard/keyboard_applet.cpp > 2b63ce78bfa6d6fbde27a66dc42d7578b12b075b > > Diff: http://git.reviewboard.kde.org/r/100557/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/100557/s/68/ > > http://git.reviewboard.kde.org/r/100557/s/69/ > > > Thanks, > > Marco > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
