----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6110/#review9229 -----------------------------------------------------------
Ship it! yeah, good catch it sucked indeed ;) - Marco On 2010-12-13 12:22:33, Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6110/ > ----------------------------------------------------------- > > (Updated 2010-12-13 12:22:33) > > > Review request for Plasma. > > > Summary > ------- > > Doing > foreach (const QString &k, elements.keys()) { > stylesheet.replace(k, elements[k]); > } > Is slower and more memory intensive than needed. Chanegd to better constructs. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/datacontainer.cpp 1206096 > /trunk/KDE/kdelibs/plasma/private/serviceprovider.cpp 1206096 > /trunk/KDE/kdelibs/plasma/theme.cpp 1206096 > > Diff: http://svn.reviewboard.kde.org/r/6110/diff > > > Testing > ------- > > None > > > Thanks, > > Albert > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
