Excuse the messing message before from me, I should top post like this since
Windows Live doesn't put arrows before each line of previous emails when
replying to them. Even though its not recommended to top post ;)
From: steven.sr...@live.ca
To: plasma-devel@kde.org
Subject: RE: Desktop Slideshow Settings
Date: Mon, 6 Dec 2010 00:42:01 -0500
On Sunday, December 5, 2010, Steven Sroka wrote:
> I'm assuming the settingsChanged() signal is emitted twice, once by 'Apply'
> and once by 'OK'. Is there anyway to stop the signal from emitting from
> the 'OK' button if the settings aren't changed (because the 'Apply' button
> has already emitted the signal and done all the necessary work)?
yes. and now that i understand what you are trying to accomplish ... :)
the problem is in BackgroundDialog::saveConfig in
kdebase/workspace/libs/plasmagenericshell/backgrounddialog.cpp
it is called when apply or ok is clicked and it unconditionally resets the
wallpaper. it probably needs to track when the wallpaper settings actually
change. right now it does this:
connect(wallpaperWidget, SIGNAL(modified(bool)), this,
SLOT(settingsModified(bool)));
settingsModified is a generic "something's changed" handler; a new slot could
be added that calls settingsModified, but which also tracks that value for the
wallpaper itself and if no changes have been made to the wallpaper config,
just not reset it.
-------------------------------------------------------------------------------------------------------------------------------I
see, now I know what to look for.I noticed that BackgroundDialog keeps track
if there are changes made through BackgroundDialog::hasChanged()Would it be
possible to add at the very beginning of BackgroundDialog::saveConfig(),if(
!hasChanged() ) { return;}orif( hasChanged() ) { //the existing code that is
run when a setting is changed.}
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
