----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6042/#review9127 -----------------------------------------------------------
Ship it! /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp <http://svn.reviewboard.kde.org/r/6042/#comment9954> const int - Aaron On 2010-12-04 14:24:09, Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6042/ > ----------------------------------------------------------- > > (Updated 2010-12-04 14:24:09) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > Allows a wider range of urls without a protocol to be accepted, like those > containing umlauts etc., queries, or IPV4-Adresses. > If no protocol has be defined, then ports aren't supported. > BUG:227380 > > Correctly handle protocols that are not a NetorkLocation or http, ftp. > BUG:228017 > > > This addresses bugs 227380 and 228017. > https://bugs.kde.org/show_bug.cgi?id=227380 > https://bugs.kde.org/show_bug.cgi?id=228017 > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp > 1203489 > > Diff: http://svn.reviewboard.kde.org/r/6042/diff > > > Testing > ------- > > ====More Urls:==== > Tried with different urls, including the one of the bug report > www.hörstreich.de, google.at, > 74.125.39.99/search?hl=en&biw=1280&bih=891&q=kde&aq=f&aqi=g10&aql=&oq=&gs_rfai= > etc. > > Problem: > There is one problem though that is unrelated to this patch and did _not_ > exist in KDE 4.5.4 > If I enter "google.at" it will display the result that I can go to > http://google.at, yet if I add ":\d" e.g. google.at:8 the result won't be > updated as nothing matches, yet the old result still stays. > In KDE 4.5.4 the old result would also disappear after a short time. > > ====Correctly handle Protocls:==== > Tried mailto:ch...@example.com, > mailto:info...@example.com?subject=current-issue and ~/kde. > > Problem: > Again this problem existed before this patch. > In BUG:167862 there is mentioned, that simply entering a folder name in your > $HOME-dir displays the folder, so instead of "~/kde" also "kde" should work. > Though this is not the case. Instead when the "Nepomuk Desktop Search Runner" > is activated just inputing "kde" works, unless it is excluded from indexing. > > > Thanks, > > Matthias > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
