----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6032/#review9099 -----------------------------------------------------------
Ship it! the mechanism for storing these preferences is so amazingly ugly :/ i've wanted default-apps-stored-in-mimetype-db for going on 6 years now, and this is a great example of why. *sigh* anyways looks ok ... /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp <http://svn.reviewboard.kde.org/r/6032/#comment9894> "if (service)" is clearer? - Aaron On 2010-12-02 19:20:32, Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6032/ > ----------------------------------------------------------- > > (Updated 2010-12-02 19:20:32) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > If no specific browser has been set as default, uses the application that is > set to open html-files. > > Ideally there would be a method in kdelibs to retrieve the default browser > though I suppose that is a different task than this bug. > > > This addresses bug 224406. > https://bugs.kde.org/show_bug.cgi?id=224406 > > > Diffs > ----- > > /trunk/KDE/kdebase/apps/dolphin/src/tests/dolphinviewtest_allviewmodes.cpp > 1202673 > /trunk/KDE/kdebase/apps/dolphin/src/tests/testbase.cpp 1202673 > > /trunk/KDE/kdebase/runtime/nepomuk/services/backupsync/gui/nepomukbackup.desktop > 1202673 > /trunk/KDE/kdebase/runtime/plasma/containments/newspaper/appletoverlay.cpp > 1202673 > /trunk/KDE/kdebase/runtime/plasma/containments/newspaper/appletsview.cpp > 1202673 > /trunk/KDE/kdebase/runtime/plasma/declarativeimports/core/theme.cpp 1202673 > /trunk/KDE/kdebase/runtime/plasma/declarativeimports/core/theme_p.h 1202673 > > /trunk/KDE/kdebase/workspace/plasma/desktop/shell/activitymanager/filterbar.cpp > 1202673 > > /trunk/KDE/kdebase/workspace/plasma/generic/containmentactions/switchactivity/switch.cpp > 1202673 > > /trunk/KDE/kdebase/workspace/plasma/generic/containmentactions/switchwindow/switch.cpp > 1202673 > > /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/activities/activities.operations > 1202673 > > /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/activities/activityengine.cpp > 1202673 > > /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/activities/activityjob.cpp > 1202673 > > /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp > 1202673 > > Diff: http://svn.reviewboard.kde.org/r/6032/diff > > > Testing > ------- > > > Thanks, > > Matthias > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel