-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5846/#review8723
-----------------------------------------------------------

Ship it!


- Aaron


On 2010-11-14 11:30:18, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5846/
> -----------------------------------------------------------
> 
> (Updated 2010-11-14 11:30:18)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> KRunner's width can be resized when it is floating.
> Also resizing on the left size is improved --> the cursor stays at the left 
> edge.
> BUG:256334
> 
> What is still not ideal is when you resize the runner on the left side and it 
> reaches the right screenboarder, then it looks a little choppy but works.
> 
> There is also still a problem existing -- unrelated to this patch: When it is 
> on top and in the middle and you resize it to the maximum, hide it, try to 
> move it ... it sometimes happens that you can't resize it anymore.
> 
> 
> Note: This review also includes http://reviewboard.kde.org/r/5844/ as I was 
> not able to do it without via post-review.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h 1196906 
>   /trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1196906 
> 
> Diff: http://svn.reviewboard.kde.org/r/5846/diff
> 
> 
> Testing
> -------
> 
> Tried different cases both in floating and non-floating:
> resizing it both on the left and right when it is centered, positioned on the 
> left or on the right
> 
> 
> Thanks,
> 
> Matthias
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to