----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5225/ -----------------------------------------------------------
(Updated 2010-09-21 18:34:04.841960) Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking. Changes ------- - add xrender support - coding style This effect doesn't hurt, is small and looks neat. It takes angular out and coherence with the rounded corners of windows, kicker, ... in. Maybe the default width of 25 pixels is too much. What do you think? Summary ------- Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect makes corners of the desktop rounded. Older Macs and Monitors had this feature too. Diffs (updated) ----- tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt 1170001 tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp 1170001 tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeLists.txt PRE-CREATION tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.desktop PRE-CREATION tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.h PRE-CREATION tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp PRE-CREATION tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.h PRE-CREATION tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.cpp PRE-CREATION tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.desktop PRE-CREATION tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.ui PRE-CREATION Diff: http://svn.reviewboard.kde.org/r/5225/diff Testing ------- Screenshots ----------- roundedcorners_without_frame http://svn.reviewboard.kde.org/r/5225/s/498/ with_simulated_border http://svn.reviewboard.kde.org/r/5225/s/499/ Thanks, Christoph
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
