----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5309/#review7527 -----------------------------------------------------------
Ship it! looks like a reasonable fix. please commit. thanks! :) - Aaron On 2010-09-10 17:25:33, Thilo-Alexander Ginkel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5309/ > ----------------------------------------------------------- > > (Updated 2010-09-10 17:25:33) > > > Review request for Plasma and Shawn Starr. > > > Summary > ------- > > As it turned out, wetter.com seems to return temperatures as decimal > fractions for some geographic regions (such as Turkey) whereas most other > regions use integers. Retrieving weather data for these regions unfortunately > failed as QString.toInt() does not work with decimal fractions. > > Example XML data showcasing this is attached to the referenced bug report. > > This fix corrects the issue by converting the data parsed from the XML to a > double and then rounds it to an integer. > > > This addresses bug 236309. > https://bugs.kde.org/show_bug.cgi?id=236309 > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/weather/ions/wetter.com/ion_wettercom.cpp > 1173706 > > Diff: http://svn.reviewboard.kde.org/r/5309/diff > > > Testing > ------- > > > Thanks, > > Thilo-Alexander > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
