----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5060/#review7111 -----------------------------------------------------------
Ship it! i like the idea, apart two little details i think it can go in trunk/KDE/kdeplasma-addons/applets/showdesktop/showdesktop.h <http://reviewboard.kde.org/r/5060/#comment7259> whitespace trunk/KDE/kdeplasma-addons/applets/showdesktop/showdesktop.cpp <http://reviewboard.kde.org/r/5060/#comment7257> watch indentation trunk/KDE/kdeplasma-addons/applets/showdesktop/showdesktop.cpp <http://reviewboard.kde.org/r/5060/#comment7258> since pressed is no more tied to actually "being pressed" perhaps should be renamed in something that makes sense semantically, like minimizeAll() - Marco On 2010-08-17 19:01:14, Sinny Kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/5060/ > ----------------------------------------------------------- > > (Updated 2010-08-17 19:01:14) > > > Review request for Plasma. > > > Summary > ------- > > Earlier, when I was trying to drag any file/folder on desktop from an opened > window , i was unable to do it because there was no option to minimize all > opened window when an item is dragged. > So, I added feature to "minimize all opened window" in "showdesktop" widget > when any item is dragged from opened window. > It's possible by hovering the mouse in dragged condition over "showdesktop" > widget icon in panel. > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/showdesktop/showdesktop.h 1162122 > trunk/KDE/kdeplasma-addons/applets/showdesktop/showdesktop.cpp 1162122 > > Diff: http://reviewboard.kde.org/r/5060/diff > > > Testing > ------- > > It works fine with trunk! > > > Thanks, > > Sinny > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
