> On 2010-08-15 07:56:46, Marco Martin wrote: > > that'a a good feature. > > would be possible separe in two commits, bugfix and feature? the bugfix one > > (and only that) should be backported to 4.5 > > obby wrote: > I definitely can split this up into two commits. Should I include the > variable renaming below (prepending m_ to member variables) in the bugfix > submit? Or should I include them as part of the feature submit (or a new > commit altogether?) > > Also, I have applied for a kdesvn account, but currently have not heard > back. I can upload an updated diff here for the feature, and an additional > diff for the bugfix, but I'll need a kind reviewer to commit each after they > pass review. > > Thanks! > > Marco Martin wrote: > yes, the variable renaming should be in the feature one. > I hope your account gets approved soon. > in the meantime i could do it if it would still not have been approved.
I've opened http://reviewboard.kde.org/r/5055/ for the bugfix. Once that is submitted, I'll have quite an easier time creating an updated diff for just the feature addition here. I'll update the description here after the bugfix is in as well. - obby ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5027/#review7060 ----------------------------------------------------------- On 2010-08-14 22:51:07, obby wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/5027/ > ----------------------------------------------------------- > > (Updated 2010-08-14 22:51:07) > > > Review request for Plasma. > > > Summary > ------- > > This patch fixes a bug wherein the very last cell in the board would never > come alive. Also, the configuration UI was updated so that using "tab" to > scroll through options would be consistent (top to bottom.) > > The patch also adds to new features: game board reflection (the user can > choose to generate initial populations that are symmetrical about the > horizontal and/or vertical axes,) and user-configurable population density > (the user can choose what approximate percentage of cells will be alive in > the initial population.) > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/life/life.h 1163310 > /trunk/KDE/kdeplasma-addons/applets/life/life.cpp 1163310 > /trunk/KDE/kdeplasma-addons/applets/life/lifeConfig.ui 1163310 > > Diff: http://reviewboard.kde.org/r/5027/diff > > > Testing > ------- > > Various game board sizes were tested (odd and even heights and widths, square > and non-square.) The configuration dialog was opened several times and tested > to confirm tab order. > > Various population densities were tested, including 0% (confirmed no cells > were alive) and 100% (confirmed that all cells were alive.) > > All combinations of vertical/horizontal/no reflection were tested at odd and > even heights and widths, square and non-square. > > Tests consisted of setting the proper configuration options, then watching > the board for a few generations and confirming that no crashes occurred and > that all cells appeared to live and die properly. > > > Screenshots > ----------- > > Updated Configuration Dialog > http://reviewboard.kde.org/r/5027/s/481/ > Board Using Vertical and Horizontal Reflection > http://reviewboard.kde.org/r/5027/s/482/ > > > Thanks, > > obby > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
