-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4955/#review6921
-----------------------------------------------------------
i won't comment on the idea itself (though it sounds good to me), but the code
is formatted very differently from the rest of the code in this applet. please
try to keep the indentation and other whitespace (e.g. how "if (foo) {"
statements are written) in patches to existing work consistent with what is
already there.
/trunk/KDE/kdeplasma-addons/applets/timer/timer.h
<http://reviewboard.kde.org/r/4955/#comment6893>
indetation incorrect
/trunk/KDE/kdeplasma-addons/applets/timer/timer.h
<http://reviewboard.kde.org/r/4955/#comment6894>
indentation
/trunk/KDE/kdeplasma-addons/applets/timer/timer.h
<http://reviewboard.kde.org/r/4955/#comment6895>
indentation
/trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp
<http://reviewboard.kde.org/r/4955/#comment6896>
put in the initializer list, following the pattern of m_running?
- Aaron
On 2010-08-09 18:05:01, Alex Raymond wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4955/
> -----------------------------------------------------------
>
> (Updated 2010-08-09 18:05:01)
>
>
> Review request for Plasma and Tomaz Canabrava.
>
>
> Summary
> -------
>
> Adds a Count Up action on the timer plasmoid, allowing it to time things :)
> Also, the ordinary Start is renamed to Count Down.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdeplasma-addons/applets/timer/timer.h 1161069
> /trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1161069
>
> Diff: http://reviewboard.kde.org/r/4955/diff
>
>
> Testing
> -------
>
> Works fine here.
>
>
> Thanks,
>
> Alex
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
