----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4947/#review6915 -----------------------------------------------------------
/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp <http://reviewboard.kde.org/r/4947/#comment6891> would it be possible to check if m_wallpaper is an absolute path and if not then do this check? also, KStandardDirs::locate or, at worse, findAllResources should be able to shortcurcuit the look up of a lot of unecessary dirs (instead of creating a Package file for each and every one)? - Aaron On 2010-08-09 15:48:31, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4947/ > ----------------------------------------------------------- > > (Updated 2010-08-09 15:48:31) > > > Review request for Plasma. > > > Summary > ------- > > This patch makes possible to specify in the config file just the wallpaper > name, such as "Ethias" or "Grass" > this would be necessary to do default plasma layouts with a different > wallpaper per containment for instance. > the patch looks like a quick and dirty way to me, another could be a Package > constructor that takesthe desktop file, or the associated KService as a path.. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp > 1157559 > > Diff: http://reviewboard.kde.org/r/4947/diff > > > Testing > ------- > > > Thanks, > > Marco > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
