On Wednesday 28 July 2010 01:18:22 Aaron J. Seigo wrote:
> On July 27, 2010, Luca Beltrame wrote:
> >  Let me know if it's OK.
> 
> in the patch, is
> 
> +          
> PythonAppletScript.importer.unregister_top_level(self.pluginName)
> 
> the proper indentation for that line? (not a pythonista, so not sure if
> what looks like extra indentation there will matter any.
> 
> otherwise, looks fine.

To me it looks like there's a mix of using tabs and spaces for indentation in 
the patch. That can be seriously confusing when trying to debug ;-)

On a completely different and OT track: is the __dtor__() method a construction 
added by sip? AFAIRC it's not from standard Python where one would use 
__del__() instead.

-- 
Best Regards / Med venlig hilsen

Thomas Olsen

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to