On 8/20/25 12:51, Ben Cooksley wrote:
On Tue, Aug 12, 2025 at 11:58 PM Nate Graham <n...@kde.org
<mailto:n...@kde.org>> wrote:
On 8/11/25 04:58, Ben Cooksley wrote:
> Unfortunately the variable in question we were trying to rely on,
> CI_MERGE_REQUEST_APPROVED is exclusive to Enterprise Edition:
>
> ben@sapphire:~/workspace/gitlab> grep -ir CI_MERGE_REQUEST_APPROVED *
> ee/app/models/ee/merge_request.rb: variables.append(key:
> 'CI_MERGE_REQUEST_APPROVED', value: approved?.to_s) if approved?
>
> As such that functionality is not available to us.
>
> This means the options available to us are:
> - Using a custom label (accessible via CI_MERGE_REQUEST_LABELS)
What does this look like?
It would be like any other label on a merge request.
See Arch for instance on https://invent.kde.org/sysadmin/repo-
metadata/-/merge_requests/614 <https://invent.kde.org/sysadmin/repo-
metadata/-/merge_requests/614> - in this case the label would be
"Approved", "Ready" or something equivalent that means a bit more than
just "Run CI"
Ah, that kind of label.
I doubt that will work. We did a variant of this for approval before
Gitlab CE backported the optional approvals feature, and it was a
complete mess. Did not work at all. I think turning off the CI for draft
merge requests would be a better approach if I had to choose between
those options.
Nate