On Thursday 15 July 2010, Manuel Mommertz wrote: > > On 2010-07-14 17:39:58, Aaron Seigo wrote: > > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/apple > > > t.cpp, lines 322-325 > > > <http://reviewboard.kde.org/r/4623/diff/3/?file=31168#file31168line322 > > > > > > > > > > these kinds of changes are really annoying. yes, rightEasement > > > isn't used right now. but what if we do use it in the future? then > > > we'll have to add this code back in. > > > > > > is the code that was removed a performance problem? no. > > > > > > was it unreadable? no. > > > > > > so why was it removed? just because. > > > > > > at one point, it ONLY supported rightEasement. when we had need for > > > leftEasement, and switched over to that, both left and right > > > easement calculation was kept so that we could easily change the > > > right/left layout decisions later on down the road. now we're back > > > to having an assumption in the code that we only have some special > > > space on the left. > > > > > > please put the rightEasement code back in ASAP. > > I discussed this with notmart already. The code isn't used at the moment > and notmart said it will not be used in the future. So removed it as the i said -probably- won't > calucaltions where wrong and why correct a not used code?. For the planed > rewrite for 4.6 I can reintroduce this in a clean way. No Problem. But as but i don't think swapping left and right in the rtl mode is actually a clean way, since is not how layouts work
> we are on this, one question: Should there be a seperator in case right > easment is used? I would do it, as the background would change to (if the > theme has one...) not for now, we can think about it if we'll use it some day Cheers, Marco Martin _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
